Fix lexgen docs: add missing packages and document generation order#1243
Open
claudeaceae wants to merge 1 commit intobluesky-social:mainfrom
Open
Fix lexgen docs: add missing packages and document generation order#1243claudeaceae wants to merge 1 commit intobluesky-social:mainfrom
claudeaceae wants to merge 1 commit intobluesky-social:mainfrom
Conversation
- Add missing lexgen commands for chat and ozone packages - Document that atproto must be generated first (other packages depend on types like com.atproto.label.defs#label) - Reorder commands to show correct generation sequence Fixes bluesky-social#727 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #727 - Updates HACKING.md to include complete lexgen documentation.
Changes
chatandozonepackages (onlybskyandatprotowere documented)atprotomust be generated first since other packages depend on its types (e.g.,com.atproto.label.defs#label)Context
The
api/directory contains four generated packages:api/atproto- com.atproto lexiconapi/bsky- app.bsky lexiconapi/chat- chat.bsky lexiconapi/ozone- tools.ozone lexiconBut HACKING.md only documented commands for the first two. This PR adds the missing commands and clarifies the generation order dependency.
🤖 Generated with Claude Code