Tap: Expose repo status via getRepoInfo#1262
Open
ThisIsMissEm wants to merge 1 commit intobluesky-social:mainfrom
Open
Tap: Expose repo status via getRepoInfo#1262ThisIsMissEm wants to merge 1 commit intobluesky-social:mainfrom
ThisIsMissEm wants to merge 1 commit intobluesky-social:mainfrom
Conversation
I noticed I'd accidentally been storing the repository state in the `status` field on my Account model, as identity events give you a status field, but if you need to ensure you have a Account record for a given DID, you probably need to call the getRepoInfo endpoint, which returns a "state" field, which I mixed up with "status" As the AccountStatus is indeed on the Repo model, I think it makes sense to return it here?
Contributor
|
I agree it makes sense to return here. It is a bit confusing having "state" and "status" next to each other where "state" references Tap sync state and "status" represents AT account status. What do you think of calling it |
Contributor
Author
|
I went with status for parity with identity events, but I agree in both cases account_status would be better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed I'd accidentally been storing the repository state in the
statusfield on my Account model, as identity events give you a status field, but if you need to ensure you have a Account record for a given DID, you probably need to call the getRepoInfo endpoint, which returns a "state" field, which I mixed up with "status"As the AccountStatus is indeed on the Repo model, I think it makes sense to return it here?