feat(tap): dynamic collection filters and multiple signal collections#1338
Open
trezy wants to merge 1 commit intobluesky-social:mainfrom
Open
feat(tap): dynamic collection filters and multiple signal collections#1338trezy wants to merge 1 commit intobluesky-social:mainfrom
trezy wants to merge 1 commit intobluesky-social:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds endpoints for dynamically updating collection filters at runtime, eliminating the need to restart Tap to add new collections.
Use case
I'm building HappyView, a lexicon-driven AppView software. I'm trying to leverage existing software in the Atmosphere that solves AppView responsibilities, such as Tap. The Tap server works well, except that we have to restart the whole server to add new collections.
This PR makes those collections dynamic, so they can be updated via an endpoint. This allows HappyView (and any other software leveraging Tap) to update the collections without further user intervention (i.e. restarting the Tap server).
New Endpoints
GET /collection-filtersPUT /collection-filtersGET /signal-collectionsPUT /signal-collectionsAll endpoints accept/return
{ "collections": ["nsid1", "nsid2"] }.Changes
signal-collectionstring flag replaced withsignal-collectionsstring slice (backwards-compatible; still readsTAP_SIGNAL_COLLECTIONenv)sync.RWMutexfor safe concurrent read/writeTapServerreceives a reference toResyncerso filter updates propagate to both firehose and resync workersTest plan
TAP_SIGNAL_COLLECTIONenv still works (backwards compat)TAP_SIGNAL_COLLECTIONSenv works with comma-separated valuesPUT /collection-filtersupdates firehose and resyncer filtering in real timePUT /signal-collectionsupdates repo discovery in real timego test ./cmd/tap/...)