Fix problem of ExternalURLHandler blocking selection of completion names#111
Open
opeongo wants to merge 1 commit intobobbylight:masterfrom
Open
Fix problem of ExternalURLHandler blocking selection of completion names#111opeongo wants to merge 1 commit intobobbylight:masterfrom
opeongo wants to merge 1 commit intobobbylight:masterfrom
Conversation
…mes. Previously, the ExternalURLHandler would be invoked even if no URL was present in the HyperLinkEvent. This would result in local names not being processed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, in an ExternalURLHandler was present it would be unconditionally invoked even if no URL was present in the HyperLinkEvent. When local link names are clicked on there is no URL,, just name in the HyperLinkEvent description, so it ends up that local names are not being processed.
With this change the ExternalURLHandler is only invoked when there is a URL to handle.