Skip to content

[Snyk] Fix for 2 vulnerabilities #5241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bogarin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #5241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion persistence-modules/querydsl/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@

<properties>
<spring.version>4.3.4.RELEASE</spring.version>
<hibernate.version>5.2.5.Final</hibernate.version>
<hibernate.version>5.3.38.Final</hibernate.version>
<hibernate-jpa.version>1.0.0.Final</hibernate-jpa.version>
<querydsl.version>4.1.4</querydsl.version>
<hsqldb.version>2.3.4</hsqldb.version>
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@
</goals>
</pluginExecutionFilter>
<action>
<ignore></ignore>
<ignore/>
</action>
</pluginExecution>
<pluginExecution>
Expand All @@ -281,7 +281,7 @@
</goals>
</pluginExecutionFilter>
<action>
<ignore></ignore>
<ignore/>
</action>
</pluginExecution>
</pluginExecutions>
Expand Down Expand Up @@ -1445,7 +1445,7 @@

<!-- logging -->
<org.slf4j.version>1.7.32</org.slf4j.version>

Copilot AI Jan 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current SLF4J version (1.7.32) is from the SLF4J 1.x series. Logback 1.5.x is designed to work with SLF4J 2.0.x, and mixing SLF4J 1.x with Logback 1.5.x may cause compatibility issues. If upgrading Logback to 1.5.x, consider also upgrading SLF4J to 2.0.x or later. However, note that SLF4J 2.0.x also requires Java 8 minimum, so the primary blocker remains the Java version requirement for Logback 1.5.x.

Suggested change
<org.slf4j.version>1.7.32</org.slf4j.version>
<org.slf4j.version>2.0.16</org.slf4j.version>

Copilot uses AI. Check for mistakes.
<logback.version>1.2.6</logback.version>
<logback.version>1.5.25</logback.version>

Copilot AI Jan 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logback 1.5.x requires Java 11 as the minimum version, but this project is configured to use Java 8 (see line 1454 where java.version is set to 1.8). Upgrading to Logback 1.5.25 will cause runtime failures when running on Java 8.

You should either:

  1. Keep Logback at 1.2.x and find the latest patch version that fixes the vulnerability (e.g., 1.2.13 if available), or
  2. Upgrade the project to Java 11+ if feasible, or
  3. Consider staying with Logback 1.3.x (which requires Java 8+) if it addresses the security vulnerability.

Additionally, upgrading Logback from 1.2.x to 1.5.x may require updating SLF4J from 1.7.32 to 2.0.x for full compatibility, as Logback 1.5.x is designed to work with SLF4J 2.0.

Suggested change
<logback.version>1.5.25</logback.version>
<logback.version>1.3.12</logback.version>

Copilot uses AI. Check for mistakes.

<!-- plugins -->
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
Expand Down