[Snyk] Fix for 2 vulnerabilities#5242
Open
bogarin wants to merge 1 commit into
Open
Conversation
…ce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-ORGHIBERNATE-15038759 - https://snyk.io/vuln/SNYK-JAVA-CHQOSLOGBACK-15062482
There was a problem hiding this comment.
Pull request overview
This PR upgrades specific Maven dependencies to address Snyk-reported vulnerabilities in Hibernate and Logback, plus a small XML formatting cleanup.
Changes:
- Bump
logback.versionin the rootpom.xmlfrom1.2.6to1.5.25and normalize<ignore>elements to self-closing tags. - Bump
hibernate-core.versioninpatterns/design-patterns-architectural/pom.xmlfrom5.2.16.Finalto5.3.38.Finalto remediate the reported Hibernate vulnerability.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.xml | Updates global Logback version for the multi-module project to remediate a Logback vulnerability and adjusts some XML <ignore> tags to self-closing form. |
| patterns/design-patterns-architectural/pom.xml | Updates the Hibernate Core version used by the architectural design-patterns module to a non-vulnerable release. |
Comments suppressed due to low confidence (1)
pom.xml:1454
- Updating
logback.versionto1.5.25while keepingorg.slf4j.versionat1.7.32andjava.versionat1.8introduces a version incompatibility: logback 1.5.x requires SLF4J 2.x and at least Java 11. This mismatch is likely to cause runtime issues (e.g.,NoSuchMethodErrordue to SLF4J API changes) or require running the build on a newer JDK than the project is configured for. Consider either upgradingorg.slf4j.version(and the Java baseline) to versions compatible with logback 1.5.x, or choosing the latest secure logback release that is still compatible with SLF4J 1.7 and Java 8 if you need to keep the current baseline.
<!-- logging -->
<org.slf4j.version>1.7.32</org.slf4j.version>
<logback.version>1.5.25</logback.version>
<!-- plugins -->
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
<maven-compiler-plugin.version>3.8.1</maven-compiler-plugin.version>
<exec-maven-plugin.version>3.0.0</exec-maven-plugin.version>
<java.version>1.8</java.version>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 2 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):
pom.xmlpatterns/design-patterns-architectural/pom.xmlVulnerabilities that will be fixed with an upgrade:
SNYK-JAVA-ORGHIBERNATE-15038759
5.2.16.Final->5.3.38.FinalProof of ConceptSNYK-JAVA-CHQOSLOGBACK-15062482
1.2.6->1.5.25ch.qos.logback:logback-core:
1.2.6->1.5.25No Known ExploitImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 SQL Injection