Skip to content

Use JsonType instead of JsonArrayType#14

Merged
boldtrn merged 2 commits intoboldtrn:masterfrom
midieuminable:master
Oct 9, 2019
Merged

Use JsonType instead of JsonArrayType#14
boldtrn merged 2 commits intoboldtrn:masterfrom
midieuminable:master

Conversation

@midieuminable
Copy link
Contributor

To be compliant with Symfony 4.2 (and furthermore to avoid deprecation in Symfony5.0)

To be compliant with Symfony 4.2 (and furthermore to avoid deprecation in Symfony5.0)
@boldtrn
Copy link
Owner

boldtrn commented Oct 1, 2019

Thanks for the PR.

It seems that the php version in the .travis file is outdated, therefore the tests failed. Could you update the .travis file to a recent php version?

Not sure if it would be required to update the composer.json to be future proof?

@midieuminable
Copy link
Contributor Author

Sorry for the delay, I updated the PHP version and the CI build passed successfully :)

@boldtrn boldtrn merged commit bef906f into boldtrn:master Oct 9, 2019
@boldtrn
Copy link
Owner

boldtrn commented Oct 9, 2019

Thanks a lot for the update. This looks good!

@boldtrn
Copy link
Owner

boldtrn commented Oct 9, 2019

I also published a new release v1.2.0 so you can use it comfortably from composer. Please let me know if this works or if anything else needs to be changed.

@midieuminable
Copy link
Contributor Author

Thanks a lot for the feedback and the new release.
Now I can clean my project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants