Skip to content

Update composer.json#391

Closed
bobdenotter wants to merge 2 commits into
masterfrom
hotfix/optimizing-composer-json
Closed

Update composer.json#391
bobdenotter wants to merge 2 commits into
masterfrom
hotfix/optimizing-composer-json

Conversation

@bobdenotter

Copy link
Copy Markdown
Member

No description provided.

@JarJak

JarJak commented Apr 11, 2019

Copy link
Copy Markdown
Member

Build fails probably due to api platform update.

@bobdenotter

Copy link
Copy Markdown
Member Author

Yes, looks like it.. I'd assumed that 2.4.2 would work where our previous dependency was 2.4.0-beta, but I guess not. :-)

@JarJak

JarJak commented Apr 12, 2019

Copy link
Copy Markdown
Member

@bobdenotter can you check which was the last working version of api platform?

@bobdenotter

bobdenotter commented Apr 13, 2019

Copy link
Copy Markdown
Member Author

Output
Using curl, with 2.4.0-beta.1, i get this:

{
  "@context": "/api/contexts/Content",
  "@id": "/api/contents",
  "@type": "hydra:Collection",
  "hydra:member": [
    {
      "@id": "/api/contents/1",
      "@type": "Content",
      "id": 1,
      "contentType": "homepage",
      "modifiedAt": "2018-10-01T22:49:28+02:00",
      "publishedAt": "2018-10-18T11:33:47+02:00",
      "fieldValues": {
        "title": "Porro quibusdam corrupti assumenda soluta earum consequatur quo.",
        "image": {
          "filename": "kitten.jpg",
          "alt": "A cute kitten",
          "path": "/thumbs/kitten.jpg?w=240&h=160&area=files"
        },
        "teaser": "Quam corrupti omnis ratione necessitatibus ipsam aut. Rem eum sequi aut sed quia doloribus illo. Minus laudantium beatae expedita nostrum sint.\n\nAt commodi eius voluptates voluptas id qui velit. Aut aut nobis hic aspernatur. Consequuntur ipsa et nostrum laborum tempore tempore. Odio dolores consectetur quis officia provident aut. Ad quis tenetur necessitatibus soluta.\n\nExercitationem sunt saepe debitis laudantium. Praesentium quasi animi non nisi. Beatae sed repudiandae quo. Expedita illo quos aperiam sunt modi quia. Natus velit quidem sit quia.",
        "content": "Voluptatem nobis veniam eum voluptatem soluta. Suscipit voluptatem quia et nesciunt. Voluptatum repudiandae aut officiis asperiores et consequatur.\n\nIste aspernatur minus commodi. Nobis et mollitia itaque in suscipit. Distinctio sunt maxime iste iusto. Ipsum ea id dolorem omnis.\n\nSunt voluptas facilis itaque placeat impedit commodi. Laborum pariatur eligendi omnis est explicabo. Et ut soluta et molestiae.",
        "contentlink": "Tempora qui id provident rerum vel.",
        "slug": "porro-quibusdam-corrupti-assumenda-soluta-earum-consequatur-quo"
      },
      "taxonomyValues": {
        "categories": {
          "events": "Events",
          "movies": "Movies"
        },
        "tags": {
          "adult": "adult",
          "biology": "biology",
          "research": "research",
          "space": "space"
        }
      },
      "authorName": "Admin",
      "extras": {
        "title": "Porro quibusdam corrupti assumenda soluta earum consequatur quo.",
        "image": {
          "filename": "kitten.jpg",
          "alt": "A cute kitten",
          "path": "/thumbs/kitten.jpg?w=240&h=160&area=files"
        },
        "excerpt": "Porro quibusdam corrupti assumenda soluta earum consequatur quo. Quam corrupti omnis …",
        "link": "/homepage/porro-quibusdam-corrupti-assumenda-soluta-earum-consequatur-quo",
        "editLink": "/bolt/edit/1"
      }
    }
  ],
  "hydra:totalItems": 1,
  "hydra:view": {
    "@id": "/api/contents?id=1",
    "@type": "hydra:PartialCollectionView"
  },
  "hydra:search": {
    "@type": "hydra:IriTemplate",
    "hydra:template": "/api/contents{?id,id[],contentType,contentType[],status,status[],createdAt,createdAt[],modifiedAt,modifiedAt[],publishedAt,publishedAt[],depublishedAt,depublishedAt[]}",
    "hydra:variableRepresentation": "BasicRepresentation",
    "hydra:mapping": [
 …
    ]
  }
}

using 2.4.0, i get this:

{
  "@context": "/api/contexts/Content",
  "@id": "/api/contents",
  "@type": "hydra:Collection",
  "hydra:member": [
    {
      "id": 1,
      "contentType": "homepage",
      "slug": "porro-quibusdam-corrupti-assumenda-soluta-earum-consequatur-quo",
      "author": {
        "id": 1,
        "displayName": "Admin",
        "username": "admin",
        "email": "admin@example.org"
      },
      "fields": {
        "title": "Porro quibusdam corrupti assumenda soluta earum consequatur quo.",
        "image": {
          "filename": "kitten.jpg",
          "alt": "A cute kitten",
          "path": "/thumbs/kitten.jpg?w=240&h=160&area=files"
        },
        "teaser": "Quam corrupti omnis ratione necessitatibus ipsam aut. Rem eum sequi aut sed quia doloribus illo. Minus laudantium beatae expedita nostrum sint.\n\nAt commodi eius voluptates voluptas id qui velit. Aut aut nobis hic aspernatur. Consequuntur ipsa et nostrum laborum tempore tempore. Odio dolores consectetur quis officia provident aut. Ad quis tenetur necessitatibus soluta.\n\nExercitationem sunt saepe debitis laudantium. Praesentium quasi animi non nisi. Beatae sed repudiandae quo. Expedita illo quos aperiam sunt modi quia. Natus velit quidem sit quia.",
        "content": "Voluptatem nobis veniam eum voluptatem soluta. Suscipit voluptatem quia et nesciunt. Voluptatum repudiandae aut officiis asperiores et consequatur.\n\nIste aspernatur minus commodi. Nobis et mollitia itaque in suscipit. Distinctio sunt maxime iste iusto. Ipsum ea id dolorem omnis.\n\nSunt voluptas facilis itaque placeat impedit commodi. Laborum pariatur eligendi omnis est explicabo. Et ut soluta et molestiae.",
        "contentlink": "Tempora qui id provident rerum vel.",
        "slug": "porro-quibusdam-corrupti-assumenda-soluta-earum-consequatur-quo"
      },
      "taxonomies": {
        "categories": {
          "events": "Events",
          "movies": "Movies"
        },
        "tags": {
          "adult": "adult",
          "biology": "biology",
          "research": "research",
          "space": "space"
        }
      },
      "extras": {
        "title": "Porro quibusdam corrupti assumenda soluta earum consequatur quo.",
        "image": {
          "filename": "kitten.jpg",
          "alt": "A cute kitten",
          "path": "/thumbs/kitten.jpg?w=240&h=160&area=files"
        },
        "excerpt": "Porro quibusdam corrupti assumenda soluta earum consequatur quo. Quam corrupti omnis …",
        "link": "/homepage/porro-quibusdam-corrupti-assumenda-soluta-earum-consequatur-quo",
        "editLink": "/bolt/edit/1"
      },
      "status": "published",
      "icon": "fa-home",
      "createdAt": "2018-11-17T03:46:15+01:00",
      "modifiedAt": "2018-10-01T22:49:28+02:00",
      "publishedAt": "2018-10-18T11:33:47+02:00",
      "depublishedAt": "2018-11-27T18:29:31+01:00"
    }
  ],
  "hydra:totalItems": 1,
  "hydra:view": {
    "@id": "/api/contents?id=1",
    "@type": "hydra:PartialCollectionView"
  },
  "hydra:search": {
    "@type": "hydra:IriTemplate",
    "hydra:template": "/api/contents{?id,id[],contentType,contentType[],status,status[],createdAt,createdAt[],modifiedAt,modifiedAt[],publishedAt,publishedAt[],depublishedAt,depublishedAt[]}",
    "hydra:variableRepresentation": "BasicRepresentation",
    "hydra:mapping": [
      …
    ]
  }
}

I've updated the test that was failing

{
"@context": "/api/contexts/Content",
"@id": "/api/contents/1",
"@type": "Content",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's strange, you shouldn't get a collection while asking for a single entity

@JarJak

JarJak commented Apr 13, 2019

Copy link
Copy Markdown
Member

Related issue: api-platform/api-platform#1018

@JarJak

JarJak commented Apr 13, 2019

Copy link
Copy Markdown
Member

I'd vote on closing this. In composer.json we should keep lowest working minor versions of dependencies, because later when someone will use Bolt as a dependency and want to use any older package version it will conflicts. As long as we can update them with composer update I don't see any issue here.

That being said, there are some packages that should be updated. These are (with minimum versions):
"coduo/php-matcher": "^3.1.2"
"phpunit/phpunit": "^8.0"
"symplify/easy-coding-standard": "^5.4.14"

and probably required php version to 7.2 and up

@JarJak JarJak closed this in #398 Apr 14, 2019
@bobdenotter
bobdenotter deleted the hotfix/optimizing-composer-json branch April 17, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants