Skip to content

Changed the output#162

Closed
sreejithsankar55 wants to merge 1 commit into
boostorg:developfrom
sreejithsankar55:second
Closed

Changed the output#162
sreejithsankar55 wants to merge 1 commit into
boostorg:developfrom
sreejithsankar55:second

Conversation

@sreejithsankar55
Copy link
Copy Markdown

Fix: #161

Tested and fixed the output in the file subgraph.cpp and subgraph.expected

@sreejithsankar55 sreejithsankar55 changed the title Second Changed the output Feb 12, 2019
@anadon
Copy link
Copy Markdown
Contributor

anadon commented Apr 5, 2019

Could you be more literal in what is incorrect? It looks like you're changing documentation and no code.

@sreejithsankar55
Copy link
Copy Markdown
Author

Could you be more literal in what is incorrect? It looks like you're changing documentation and no code.
@anadon The output in the documentation of subgraph.expected and the commented part of subgraph.cpp is wrong when I tested the code locally, it produces a different output rather than the expected. Hence, I changed it to exactly what the code produces as the output.

@anadon
Copy link
Copy Markdown
Contributor

anadon commented Apr 6, 2019

I have serious misgivings about correctness here. Those examples are old and when they were originally made they were very likely validated. It it possible internal behavior has changes or there is a bug, but you're going to need to provide a test case.

How are you generating your results? Please include your code.

@Becheler
Copy link
Copy Markdown
Collaborator

Thank you for opening this issue and proposing a PR 😄
I will close this issue as stale and can not replicate, as well as its related issue #161
This is also superseded by the documentation migration to Antora #491 where examples output are regenerated in CI.
Thanks again 🙏🏽

@Becheler Becheler closed this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expected outputs of subgraph is incorrect

4 participants