You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could you be more literal in what is incorrect? It looks like you're changing documentation and no code. @anadon The output in the documentation of subgraph.expected and the commented part of subgraph.cpp is wrong when I tested the code locally, it produces a different output rather than the expected. Hence, I changed it to exactly what the code produces as the output.
I have serious misgivings about correctness here. Those examples are old and when they were originally made they were very likely validated. It it possible internal behavior has changes or there is a bug, but you're going to need to provide a test case.
How are you generating your results? Please include your code.
Thank you for opening this issue and proposing a PR 😄
I will close this issue as stale and can not replicate, as well as its related issue #161
This is also superseded by the documentation migration to Antora #491 where examples output are regenerated in CI.
Thanks again 🙏🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #161
Tested and fixed the output in the file subgraph.cpp and subgraph.expected