hashindex: fix iterator implementation - #1659
Merged
Merged
Conversation
NSKeyIterator and ChunkKeyIterator raised StopIteration once only when they reached their end. But they did not raise StopIteration if one called next() again after they were exhausted, so they did not comply to the standard iterator protocol. AFAIK, this did not cause actual problems due to the way these iterators are used, but when I tried to use itertools.islice() to get n-long sequences from these iterators, it failed / went into an endless loop.
Member
Author
|
@RonnyPfannschmidt this is why I couldn't get islice working. ^^^ |
Current coverage is 81.90% (diff: 100%)@@ 1.0-maint #1659 diff @@
===========================================
Files 15 15
Lines 4780 4780
Methods 0 0
Messages 0 0
Branches 815 815
===========================================
Hits 3915 3915
Misses 631 631
Partials 234 234
|
Contributor
|
Yelp |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSKeyIterator and ChunkKeyIterator raised StopIteration once only when they reached their end.
But they did not raise StopIteration if one called next() again after they were exhausted,
so they did not comply to the standard iterator protocol.
AFAIK, this did not cause actual problems due to the way these iterators are used,
but when I tried to use itertools.islice() to get n-long sequences from these iterators,
it failed / went into an endless loop.