avoid orphan content chunks (master) - #7349
Merged
ThomasWaldmann merged 5 commits intoFeb 13, 2023
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #7349 +/- ##
==========================================
- Coverage 84.01% 83.91% -0.10%
==========================================
Files 67 67
Lines 11678 11687 +9
Branches 2124 2125 +1
==========================================
- Hits 9811 9807 -4
- Misses 1306 1319 +13
Partials 561 561
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ThomasWaldmann
marked this pull request as draft
February 12, 2023 19:12
ThomasWaldmann
force-pushed
the
avoid-orphan-content-chunks3
branch
from
February 12, 2023 19:13
35f5984 to
8db3b39
Compare
ThomasWaldmann
force-pushed
the
avoid-orphan-content-chunks3
branch
from
February 13, 2023 17:24
a827af3 to
ac85946
Compare
ThomasWaldmann
marked this pull request as ready for review
February 13, 2023 19:35
we do book-keeping in item.chunks: in case something goes wrong and we need to clean up, we will have a list with chunks to decref in item.chunks. also: - make variable naming more consistent - cosmetic changes
…case of exceptions Note: no changes inside the indented block, just added the try and the except block.
ThomasWaldmann
force-pushed
the
avoid-orphan-content-chunks3
branch
from
February 13, 2023 19:47
ac85946 to
71f8dd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that #7310 only solves part of the problem, because we incref chunks at other places, too, and we need to cleanup these also in case some exception happens.
Also, we might have exceptions between writing the chunks and writing the metadata item referencing them.