Skip to content

do not crash for empty archives list in borg rlist date based matching - #7544

Merged
ThomasWaldmann merged 5 commits into
borgbackup:masterfrom
jetchirag:jetchirag-patch-1
May 20, 2023
Merged

do not crash for empty archives list in borg rlist date based matching#7544
ThomasWaldmann merged 5 commits into
borgbackup:masterfrom
jetchirag:jetchirag-patch-1

Conversation

@jetchirag

Copy link
Copy Markdown
Contributor

Fixes #7522

@codecov-commenter

codecov-commenter commented May 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7544 (d35436c) into master (7a13a98) will decrease coverage by 0.03%.
The diff coverage is 60.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #7544      +/-   ##
==========================================
- Coverage   83.77%   83.74%   -0.03%     
==========================================
  Files          66       66              
  Lines       11785    11789       +4     
  Branches     2150     2152       +2     
==========================================
  Hits         9873     9873              
- Misses       1338     1341       +3     
- Partials      574      575       +1     
Impacted Files Coverage Δ
src/borg/manifest.py 93.03% <60.00%> (-0.88%) ⬇️

... and 2 files with indirect coverage changes

Comment thread src/borg/manifest.py Outdated
Comment thread src/borg/testsuite/archiver/check_cmd.py

@ThomasWaldmann ThomasWaldmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this, see the inline comment.

@ThomasWaldmann ThomasWaldmann changed the title Added a check on timestamp to prevent ValueError in borg rlist date based matching do not crash for empty archives list in borg rlist date based matching May 19, 2023
…put)

Signed-off-by: Chirag Aggarwal <thechiragaggarwal@gmail.com>
@ThomasWaldmann
ThomasWaldmann merged commit eeefa55 into borgbackup:master May 20, 2023
@ThomasWaldmann

Copy link
Copy Markdown
Member

Thanks!

@jetchirag
jetchirag deleted the jetchirag-patch-1 branch May 20, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Borg2: ValueError on date-based matching

3 participants