ChunkIndexEntry.refcount -> .flags#8513
Merged
ThomasWaldmann merged 4 commits intoNov 2, 2024
Merged
Conversation
We gave up refcounting quite a while ago and are only interested in whether a chunk is used (referenced) or not (orphan). So, let's keep that uint32_t value, but use it for bit flags, so we could use it to efficiently remember other chunk-related stuff also.
we changed the semantics (and name) of the first tuple element: refcount -> flags thus, better invalidate existing cache.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8513 +/- ##
==========================================
+ Coverage 81.72% 81.76% +0.04%
==========================================
Files 73 73
Lines 13109 13140 +31
Branches 1924 1926 +2
==========================================
+ Hits 10713 10744 +31
Misses 1740 1740
Partials 656 656 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make better use of these 32bits.