testsuite: add argon2 wrong-passphrase test for decrypt_key_file, refs #9686#9691
Merged
ThomasWaldmann merged 1 commit intoMay 31, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9691 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 93 93
Lines 15586 15586
Branches 2335 2335
=======================================
+ Hits 13085 13086 +1
+ Misses 1776 1775 -1
Partials 725 725 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One test for
decrypt_key_file_argon2, refs #9686.Follow-up to #9686, which added wrong-passphrase coverage for the PBKDF2 path.
decrypt_key_filecallsdecrypt_key_file_argon2when the stored algorithm isargon2 chacha20-poly1305. Wrong passphrase, different derived key, Poly1305 auth fails,Noneback. Same contract as PBKDF2.Added to
src/borg/testsuite/crypto/key_test.py:None: Argon2 derives a different key, Poly1305 check fails,Nonereturned (not raised)BORG_TESTONLY_WEAKEN_KDFis set globally inconftest.py, so Argon2 runs with minimal parameters.No production code changes.
Refs #9686
Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)