tests: date: filter runs local,binary (drop remote)#9920
Merged
ThomasWaldmann merged 1 commit intoJul 21, 2026
Conversation
The date: archive match selector is client-side manifest filtering with no transport-specific behavior, so the "remote" archiver kind adds no coverage. Per the kind-picking policy in testsuite/archiver/__init__.py (borgbackup#9324), pure command/formatting logic belongs in the local,binary bucket. Dropping remote avoids ~33 needless REST-server round-trip sessions for this file. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9920 +/- ##
==========================================
+ Coverage 85.38% 85.44% +0.06%
==========================================
Files 93 93
Lines 16012 16099 +87
Branches 2444 2464 +20
==========================================
+ Hits 13672 13756 +84
- Misses 1632 1634 +2
- Partials 708 709 +1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8776.
The
date:archive match selector (added in #8776) is client-side manifest filtering — it has no transport-specific behavior. Its test file was running withkinds="local,remote,binary", but theremotekind adds no coverage here.Per the kind-picking policy documented in
src/borg/testsuite/archiver/__init__.py(introduced by the #9324 testsuite speedup),remoteshould only be used where a backend genuinely branches its implementation per transport; pure command/formatting logic belongs in thelocal,binarybucket.This file expands to ~33 test instances, each creating a repo and archives, so the
remoteleg was spawning ~33 REST-server round-trip sessions for zero extra coverage. This dropsremote:🤖 Generated with Claude Code