Fix manual path entry in file dialog not working #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users type a path in the file dialog path bar and click Add without selecting anything in the tree, the path bar text is now used as the selection. Previously, the path bar only navigated the tree view and users had to click items in the tree to select them.
m3nu
force-pushed
the
fix-manual-path-entry
branch
from
32682b8 to
59784b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When users type a path in the Sources tab file dialog path bar and click "Add" without selecting anything in the tree, nothing happens. This is because the path bar was only used for navigation - users had to click items in the tree to select them, with no UI indication of this.
This PR modifies
selected_paths()infiledialog.pyto fall back to the path bar text when no tree items are selected, allowing users to directly add a path by typing it.Test plan
/tmp)