fix: usdc approve fails from dcl - #469
Merged
Merged
Conversation
levalleux-ludo
marked this pull request as ready for review
March 29, 2023 13:23
levalleux-ludo
changed the title
Codecov Report
@@ Coverage Diff @@
## releases/mvfw-2023 #469 +/- ##
======================================================
+ Coverage 54.65% 55.79% +1.13%
======================================================
Files 127 121 -6
Lines 3692 3459 -233
Branches 629 573 -56
======================================================
- Hits 2018 1930 -88
+ Misses 1674 1529 -145
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
USDC approval meta-tx signing fails only when called from DCL
This was coming from getNonce() implementation that retries with "nonces" instead of "getNonce" only when failing and the error message matches the one returned by Metamask. However on DCL, we are using an HTTP provider instead of Metamask and the error message is not the same.
How to test
N/A