fix(desktop): show shared relay agents in mention autocomplete [fork CI] - #1
Closed
bossriceshark wants to merge 5 commits into
Closed
fix(desktop): show shared relay agents in mention autocomplete [fork CI]#1bossriceshark wants to merge 5 commits into
bossriceshark wants to merge 5 commits into
Conversation
Mention candidates were dropped by isAgentIdentityInManagedList before shouldHideAgentFromMentions ever ran, so remote relay agents — which can never enter the local managed list (apply_inbound_managed_agent is patch-only by design) — were unmentionable on desktop even when their kind:10100 directory records made them eligible. Mobile has no such filter and shows them. Admit candidates through the mentionable set (managed agents plus directory-eligible relay agents) instead — the same eligibility useNewMessageRecipients already trusts. Agents in neither set stay hidden, preserving the guard's anti-impersonation posture. isAgentIdentityInManagedList is unchanged for its remaining consumer (MembersSidebar add-member search). Signed-off-by: Matt Rice <bossriceshark@users.noreply.github.com>
Review findings: the case-normalization assertion used a digit-only fixture (toUpperCase() is identity on digits, so it could never fail) — replaced with a letter-bearing hex fixture; pinned the member-agent- without-directory-record path explicitly; converted the new export's comment to JSDoc per repo convention; noted that the shouldHideAgentFromMentions member branch is gated upstream. Signed-off-by: Matt Rice <bossriceshark@users.noreply.github.com>
The mention-priority smoke test asserted alice hidden — alice is the mock's shared relay agent (directory respond_to "anyone" with a shared channel, channel member, not locally managed), which is exactly the candidate class the fix admits. Update expectations to the fixed behavior and pin her member-tier ordering. Signed-off-by: Matt Rice <bossriceshark@users.noreply.github.com>
….mjs main currently fails `biome check .` on these two string concatenations; recent main pushes were docs-only so the path-filtered desktop CI job never surfaced it. Included here so this PR's CI can run green — happy to split into its own PR if preferred. Signed-off-by: Matt Rice <bossriceshark@users.noreply.github.com>
Signed-off-by: Matt Rice <bossriceshark@users.noreply.github.com>
Owner
Author
|
Fork CI verification complete (all checks green). Upstream PR: block#4137 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal draft PR to run desktop CI on the fix branch. Not for merge here — the upstream PR to block/buzz follows once CI is green. See commit messages for the change description.