Add Python 3 compatibility.#8
Merged
Merged
Conversation
|
Hi, is there any problem with merging this? Python 3 would be welcomed! :) |
gholms
approved these changes
Nov 18, 2016
Contributor
gholms
left a comment
gholms
left a comment
There was a problem hiding this comment.
This is a good start! There are still some unicode/bytes issues to sort out before we can officially say that this supports Python 3, but this should take care of many of the more pervasive 2-isms.
| from requestbuilder.util import add_default_routes, aggregate_subclass_fields | ||
|
|
||
|
|
||
| import six |
Contributor
There was a problem hiding this comment.
Per PEP 8, third party library imports come between standard library imports and local imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.