Fixed the collaborations response properties#149
Closed
Conversation
Removed pagination schema Added next_marker property Added previous_marker property IMPORTANT: I would have used the marker_pagination like in the Folder Locks resource but there does not seem to be a limit property in this response.
Contributor
Author
|
After more testing something is more strange here. I think it would be a mistake to change this resource. It seems the List File Collaborations request has the wrong response not that this resource is in correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed pagination schema
Added next_marker property
Added previous_marker property
IMPORTANT: I would have used the marker_pagination like in the Folder Locks resource but there does not seem to have a limit property in this response.
Description
Please include a summary of the change and which issue is fixed.
If you are a Boxer, please also reference the related
DDOCorAPIWGtickets.If you do not have a related
Jiraticket and this is more than a bug fix, thencreate one now.
Fixes #148
Checklist
yarn lintto make sure my changes pass all lintersContribution guidelines
For contribution guidelines, styleguide, and other helpful information please
see the
CONTRIBUTING.mdfile in the root of this project.