Fix issue where only the last database's connection was used in QueryAsserter#205
Merged
Fix issue where only the last database's connection was used in QueryAsserter#205
Conversation
arahayrabedian
force-pushed
the
fix_connection_confusion
branch
2 times, most recently
from
2c4d761 to
2c59909
Compare
…Asserter (where "last" is internal ordering)
arahayrabedian
force-pushed
the
fix_connection_confusion
branch
from
2c59909 to
e6dc0c0
Compare
jedie
reviewed
Feb 9, 2026
jedie
reviewed
Feb 9, 2026
jedie
reviewed
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueryAsserterwould only pick the last database used, this was not visible in our setup but will cause queries to go to the wrong database.Fix is to make sure that
connectiongets appropriately set in each cursor.