Fix freeze on shutdown with eternal microtasks #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpcreech
force-pushed
the
feature/no-freeze-on-shutdown
branch
from
a587746 to
f559678
Compare
bpcreech
force-pushed
the
feature/no-freeze-on-shutdown
branch
from
f559678 to
d5bdc1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_interrupts_background_task_on_shutdowncontains an example infinite-loop microtask which would (without this change) prevent MiniRacer from ever exiting.This also adds an explicit
closeand context manager aroundMiniRaceron the Python side, which would have been nice to have already, and is useful here to write the unit test.