feat(acme): add short-name aliases for ACME resources

[bpg-dev]

What does this PR do?

Adds short-name proxmox_* aliases for all ACME resources and datasources as part of ADR-007 Phase 2:

Resources: proxmox_acme_account, proxmox_acme_dns_plugin
Data sources: proxmox_acme_account, proxmox_acme_accounts, proxmox_acme_plugin, proxmox_acme_plugins

Old names emit a deprecation warning. Resources implement MoveState for Terraform moved block support. Old docs show a deprecation banner. Existing acceptance tests updated to use short names.

Review fixes

• Replace resource.Test with resource.ParallelTest in all ACME test files (ADR-006); remove explicit t.Parallel() from datasource tests to avoid Go 1.26 double-call panic
• Add ImportState/ImportStateVerify round-trip test steps for both resources (ADR-006)
• Add inline // proxmox_* comments on all short-name registrations in provider.go (consistency with access resources)
• Fix quadruplicated MPL license header in resource_acme_account.go (pre-existing copy-paste artifact)

Contributor's Note

• I have run make lint and fixed any issues.
• I have updated documentation (FWK: schema descriptions + make docs; SDK: manual /docs/ edits).
• I have added / updated acceptance tests (required for new resources and bug fixes — see ADR-006).
• I have considered backward compatibility (no breaking schema changes without ! in PR title).

Proof of Work

--- PASS: TestAccResourceACMEDNSPlugin (2.92s)
    --- PASS: TestAccResourceACMEDNSPlugin/invalid_validation_delay (0.54s)
    --- PASS: TestAccResourceACMEDNSPlugin/plugin_with_validation_delay (1.18s)
    --- PASS: TestAccResourceACMEDNSPlugin/update_plugin (1.69s)
    --- PASS: TestAccResourceACMEDNSPlugin/plugin_with_disable_flag (2.18s)
    --- PASS: TestAccResourceACMEDNSPlugin/basic_plugin_creation (2.40s)
--- PASS: TestAccResourceACMEAccount (5.42s)
    --- PASS: TestAccResourceACMEAccount/invalid_directory_URL (0.42s)
    --- PASS: TestAccResourceACMEAccount/basic_account_creation (3.64s)
    --- PASS: TestAccResourceACMEAccount/account_with_EAB (4.38s)
    --- PASS: TestAccResourceACMEAccount/update_account (4.91s)
--- PASS: TestAccDatasourceACMEAccount (4.39s)
--- PASS: TestAccDatasourceACMEAccounts (4.26s)
--- PASS: TestAccDatasourceACMEPlugin (0.86s)
--- PASS: TestAccDatasourceACMEPlugins (5.56s)

make lint → 0 issues
make build → pass

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #2133

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Proxmox Terraform provider by introducing a set of user-friendly short-name aliases for existing ACME-related resources and data sources. This change streamlines the configuration experience for users, while ensuring backward compatibility through deprecation warnings and robust state migration capabilities. The update is a key step in the ongoing resource type name migration strategy.

Highlights

• Short-name Aliases for ACME Resources and Data Sources: Introduced new short-name aliases for proxmox_acme_account, proxmox_acme_dns_plugin resources and proxmox_acme_account, proxmox_acme_accounts, proxmox_acme_plugin, proxmox_acme_plugins data sources, aligning with ADR-007.
• Deprecation Warnings: Configured the original ACME resource and data source names to emit deprecation warnings, guiding users towards the new short-name aliases.
• State Migration Support: Implemented MoveState functionality for the proxmox_acme_account and proxmox_acme_dns_plugin resources, enabling seamless state migration for moved blocks.
• Documentation Updates: Added comprehensive documentation for all new short-name ACME resources and data sources.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements the short-name aliasing for ACME resources and data sources as outlined in ADR-007. The changes are well-structured, using embedding for code reuse and implementing MoveState for a smooth user migration path. The old resource names are correctly marked as deprecated. I have a few suggestions to improve the clarity of the documentation for the newly added files.