[CLOSED] [NOT READY] fix some linux compile issues with CEF 2171

[core-ai-bot]

Issue by jasonsanjose
Thursday Dec 04, 2014 at 00:46 GMT
Originally opened as adobe#489

---

This PR fixes some compile issues, but I'm still seeing errors that I haven't been able to resolve:

jasonsj@ubuntu:~/Github/brackets-shell$ grunt build
Running "build" task

Running "build-linux" task
>> out/Release/obj.target/Brackets/appshell/cefclient_gtk.o: In function `main':
>> cefclient_gtk.cpp:(.text+0x7cc): undefined reference to `CefExecuteProcess(CefMainArgs const&, CefRefPtr<CefApp>, void*)'
>> cefclient_gtk.cpp:(.text+0xb99): undefined reference to `CefInitialize(CefMainArgs const&, CefStructBase<CefSettingsTraits> const&, CefRefPtr<CefApp>, void*)'
>> cefclient_gtk.cpp:(.text+0xff1): undefined reference to `CefBrowserHost::CreateBrowser(CefWindowInfo const&, CefRefPtr<CefClient>, CefStringBase<CefStringTraitsUTF16> const&, CefStructBase<CefBrowserSettingsTraits> const&, CefRefPtr<CefRequestContext>)'
>> out/Release/obj.target/libcef_dll_wrapper/libcef_dll/wrapper/libcef_dll_wrapper.o: In function `CefShutdown()':
>> libcef_dll_wrapper.cc:(.text+0x2ac): undefined reference to `CefCppToC<CefCompletionHandlerCppToC, CefCompletionHandler, _cef_completion_handler_t>::DebugObjCt'
>> libcef_dll_wrapper.cc:(.text+0x365): undefined reference to `CefCToCpp<CefDOMEventCToCpp, CefDOMEvent, _cef_domevent_t>::DebugObjCt'
>> libcef_dll_wrapper.cc:(.text+0x38a): undefined reference to `CefCppToC<CefDOMEventListenerCppToC, CefDOMEventListener, _cef_domevent_listener_t>::DebugObjCt'
>> libcef_dll_wrapper.cc:(.text+0x952): undefined reference to `CefCppToC<CefTraceClientCppToC, CefTraceClient, _cef_trace_client_t>::DebugObjCt'
>> out/Release/obj.target/libcef_dll_wrapper/libcef_dll/wrapper/libcef_dll_wrapper.o: In function `CefGetTraceBufferPercentFullAsync()':
>> libcef_dll_wrapper.cc:(.text+0x12a9): undefined reference to `cef_get_trace_buffer_percent_full_async'
>> out/Release/obj.target/libcef_dll_wrapper/libcef_dll/wrapper/libcef_dll_wrapper.o: In function `CefEndTracingAsync()':
>> libcef_dll_wrapper.cc:(.text+0x12c2): undefined reference to `cef_end_tracing_async'
>> out/Release/obj.target/libcef_dll_wrapper/libcef_dll/wrapper/libcef_dll_wrapper.o: In function `CefCppToC<CefTraceClientCppToC, CefTraceClient, _cef_trace_client_t>::Wrap(CefRefPtr<CefTraceClient>)':
>> libcef_dll_wrapper.cc:(.text._ZN9CefCppToCI20CefTraceClientCppToC14CefTraceClient19_cef_trace_client_tE4WrapE9CefRefPtrIS1_E[_ZN9CefCppToCI20CefTraceClientCppToC14CefTraceClient19_cef_trace_client_tE4WrapE9CefRefPtrIS1_E]+0x4f): undefined reference to `CefTraceClientCppToC::CefTraceClientCppToC(CefTraceClient*)'
>> out/Release/obj.target/libcef_dll_wrapper/libcef_dll/ctocpp/domnode_ctocpp.o: In function `CefCppToC<CefDOMEventListenerCppToC, CefDOMEventListener, _cef_domevent_listener_t>::Wrap(CefRefPtr<CefDOMEventListener>)':
>> domnode_ctocpp.cc:(.text._ZN9CefCppToCI25CefDOMEventListenerCppToC19CefDOMEventListener24_cef_domevent_listener_tE4WrapE9CefRefPtrIS1_E[_ZN9CefCppToCI25CefDOMEventListenerCppToC19CefDOMEventListener24_cef_domevent_listener_tE4WrapE9CefRefPtrIS1_E]+0x4f): undefined reference to `CefDOMEventListenerCppToC::CefDOMEventListenerCppToC(CefDOMEventListener*)'
>> collect2: error: ld returned 1 exit status
>> make: * [out/Release/Brackets] Error 1
Warning: Task "build-linux" failed. Use --force to continue.

Aborted due to warnings.

The closest thing I've found on the forums is http://www.magpcss.org/ceforum/viewtopic.php?f=6&t=10786, but making the suggested change to appshell.gyp, running grunt setup and grunt build again doesn't improve anything.

Another notable bug with 2171 is that the sample cefclient doesn't build with Ubuntu 14.04 https://code.google.com/p/chromiumembedded/issues/detail?id=1430. It's patched later in build 3.2171.1941,

---

jasonsanjose included the following code: https://github.com/adobe/brackets-shell/pull/489/commits

[core-ai-bot]

Comment by jasonsanjose
Thursday Dec 04, 2014 at 00:49 GMT

---

FYI below is the current error message when building linux on the current jeff/cef_2171_mac branch. This PR fixes these issues, but introduces a new one (see description above).

jasonsj@ubuntu:~/Github/brackets-shell$ grunt build
Running "build" task

Running "build-linux" task
>> In file included from appshell/command_callbacks.h:4:0,
>>                  from appshell/client_handler.h:15,
>>                  from appshell/appshell_extensions.h:27,
>>                  from appshell/appshell_extensions.cpp:24:
>> appshell/appshell_extensions_platform.h: In function ‘void* getMenuParent(CefRefPtr<CefBrowser>)’:
>> appshell/appshell_extensions_platform.h:65:57: error: ‘GTK_WIDGET’ was not declared in this scope
>>          GTK_WIDGET(browser->GetHost()->GetWindowHandle()),
>>                                                          ^
>> appshell/appshell_extensions_platform.h:66:9: error: ‘GTK_TYPE_VBOX’ was not declared in this scope
>>          GTK_TYPE_VBOX);
>>          ^
>> appshell/appshell_extensions_platform.h:66:22: error: ‘gtk_widget_get_ancestor’ was not declared in this scope
>>          GTK_TYPE_VBOX);
>>                       ^
>> make: * [out/Release/obj.target/Brackets/appshell/appshell_extensions.o] Error 1
Warning: Task "build-linux" failed. Use --force to continue.

Aborted due to warnings.

[core-ai-bot]

Comment by ingorichter
Thursday Dec 04, 2014 at 01:07 GMT

---

let me check this out. Thanks @jasonsanjose.

[core-ai-bot]

Comment by jasonsanjose
Friday Dec 05, 2014 at 23:21 GMT

---

Current build error:

jasonsj@ubuntu:~/Github/brackets-shell$ grunt build
Running "build" task

Running "build-linux" task
>> /usr/bin/ld: out/Release/obj.target/libcef_dll_wrapper/libcef_dll/base/cef_lock_impl.o: undefined reference to symbol 'pthread_mutexattr_settype@@GLIBC_2.2.5'
>> //lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
>> collect2: error: ld returned 1 exit status
>> make: * [out/Release/Brackets] Error 1
Warning: Task "build-linux" failed. Use --force to continue.

Aborted due to warnings.

[core-ai-bot]

Comment by Mark-Simulacrum
Saturday Dec 06, 2014 at 00:21 GMT

---

I'm currently getting the following upon launching Brackets, and selecting index.html:

[1205/172059:ERROR:browser_main_loop.cc(163)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[1205/172059:ERROR:browser_main_loop.cc(209)] Gdk: /build/buildd/gtk+2.0-2.24.23/gdk/x11/gdkdrawable-x11.c:952 drawable is not a pixmap or window
[1205/172059:ERROR:renderer_main.cc(207)] Running without renderer sandbox
[1205/172059:ERROR:sandbox_linux.cc(305)] InitializeSandbox() called with multiple threads in process gpu-process
[1]    19622 segmentation fault  ./Brackets

[core-ai-bot]

Comment by peterflynn
Saturday Dec 06, 2014 at 00:58 GMT

---

@Mark-Simulacrum Hmm, interesting... someone hit that recently when trying to run generic cefclient too: adobe/brackets#6427 (comment).

These Chromium docs imply Chromium expects to find a root-owned special permissions executable in /usr/local/sbin/chrome-devel-sandbox... that would be a pain for us to try to auto-install, but I feel like we shouldn't have to: the name alone implies that it's a utility intended only for use in a dev environment, not for end users. I wonder what we could do instead? That docs page says only "Package maintainers should make sure the setuid binary is installed and defined in GYP as linux_sandbox_path." (@ingorichter, does that line make any sense to you?)

[core-ai-bot]

Comment by ingorichter
Saturday Dec 06, 2014 at 00:59 GMT

---

Yes, I see the same issue. I see two Windows in the beginning and then Brackets crashes. I can't find the core dumps on my Ubuntu 14.10 system. @Mark-Simulacrum do you know where they hide?

[core-ai-bot]

Comment by peterflynn
Saturday Dec 06, 2014 at 01:01 GMT

---

In CEF bug #524, Marshall says "Linux: For binary distributions a new chrome-sandbox executable with SUID permissions must be placed next to the CEF executable." Odd that their own cefclient distros seem to be failing to do that correctly, though... bug on their end, maybe?

[core-ai-bot]

Comment by Mark-Simulacrum
Saturday Dec 06, 2014 at 01:05 GMT

---

@ingorichter No, and I can't seem to find anything about core dumps. I haven't done much development though. Will post back if I find more information.

[core-ai-bot]

Comment by ingorichter
Saturday Dec 06, 2014 at 01:10 GMT

---

The funny thing is, that we have disabled sandboxing on Windows, OSX and Linux. The docs recommended this (if you are certain to understand what you are doing by disabling this security feature).
I'd like to have a look at the core dump to rule out any other issue. Usually Chrome shouldn't crash when running without the sandbox executable.

[core-ai-bot]

Comment by Mark-Simulacrum
Saturday Dec 06, 2014 at 01:12 GMT

---

I may have found the way to access the coredump, but I'm not completely certain. Execute ulimit -c unlimited (sets core file size to unlimited) and then attempt to reproduce the bug. A core file should show up in the current working directory.

[core-ai-bot]

Comment by Mark-Simulacrum
Saturday Dec 06, 2014 at 01:17 GMT

---

@ingorichter gdb --core=core will allow you to view the file, for more information: http://manpages.ubuntu.com/manpages/saucy/man5/core.5.html, http://askubuntu.com/questions/63796/how-do-i-view-coredump-file

[core-ai-bot]

Comment by ingorichter
Saturday Dec 06, 2014 at 01:47 GMT

---

Thanks @Mark-Simulacrum. That created the core file for me. Now I need to get the symbols for gtk and see where exactly the crash happens.

[core-ai-bot]

Comment by Mark-Simulacrum
Monday Dec 08, 2014 at 12:45 GMT

---

@ingorichter After pulling in your fix, I can now launch Brackets (successfully): but I can't get the HTML content to expand when changing the window size. Also, the DevTools launch in a new window, not in Chrome as they used to. Here's my log:

[1208/054302:ERROR:browser_main_loop.cc(163)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[1208/054302:ERROR:renderer_main.cc(207)] Running without renderer sandbox
ATTENTION: default value of option force_s3tc_enable overridden by environment.
[1208/054302:ERROR:sandbox_linux.cc(305)] InitializeSandbox() called with multiple threads in process gpu-process
[1208/054302:ERROR:gpu_process_transport_factory.cc(437)] Failed to establish GPU channel.
[1208/054349:ERROR:renderer_main.cc(207)] Running without renderer sandbox

[core-ai-bot]

Comment by ingorichter
Monday Dec 08, 2014 at 18:24 GMT

---

@Mark-Simulacrum DevTools will no longer open in a separate Chrome window. This is something that was introduced some months ago. I saw the issue with the window not properly resizing. I need to look into the code that resizes the window and propagates the event.

[core-ai-bot]

Comment by redmunds
Monday Dec 08, 2014 at 18:37 GMT

---

DevTools will no longer open in a separate Chrome window

This is the behavior when opening Dev Tools from Brackets. But if you need or prefer using a Chrome window, you can open one manually and navigate to localhost:9234