detach bash on windows.

[core-ai-bot]

Issue by taichi
Thursday Mar 20, 2014 at 07:34 GMT
Originally opened as adobe#431

---

windows don't have bash commands.
so switch to javascript.

---

taichi included the following code: https://github.com/adobe/brackets-shell/pull/431/commits

[core-ai-bot]

Comment by bchintx
Thursday Mar 20, 2014 at 17:27 GMT

---

@taichi - can you please clarify why you'd like to make these changes? brackets-shell builds just fine on Windows currently so long as you have the right dev environment pre-requisites, such as GitBash. More information on building on Windows can be found here.

[core-ai-bot]

Comment by taichi
Friday Mar 21, 2014 at 03:36 GMT

---

this change prevents most Windows users from small pitfall.

most Windows users launch the bash terminal dedicated only when using Git.
For example, I select "Git Bash" from the context menu of Windows Explorer for start the bash terminal.

most Windows users are using the cmd terminal when using grunt and npm.
bash.exe is not included in the PATH environment variable of the user who is using bash terminal of git only.
So, if you run npm install in cmd terminal, GitBash has been installed, it's an error to not find the unzip.exe and bash.exe.

[core-ai-bot]

Comment by bchintx
Friday Mar 21, 2014 at 21:22 GMT

---

Ah, gotcha. Thanks for the clarification.

I understand your motivation, but many of our developers, including myself, use Git Bash as our Brackets command-line environment on Windows. Unfortunately, your change will break our environments.

In short, if you're hacking on Brackets on Windows. Please be sure to use the Git Bash terminal to interact with git and run the grunt scripts as already documented in the Building Brackets Shell for Windows Wiki. Thanks!

Alternatively, you could submit an alternate set of commands or scripts that might be more "Command Prompt"-friendly, without breaking the existing scripts which leverage Git Bash.

[core-ai-bot]

Comment by taichi
Monday Mar 24, 2014 at 10:57 GMT

---

this change don't change script behavior.
so my change will not break your environments.

[core-ai-bot]

Comment by JeffryBooher
Tuesday Apr 08, 2014 at 20:20 GMT

---

@taichi these changes do change the tools used to in the shell's build script so the behavior hasn't changed -- no, but the tools used to build the shell have changed. These may cause our automated scripts to fail and it could cause users with limited rights the inability to build.

Adm-zip would need to be installed npm -g adm-zip which isn't part of the grunt process and added as a node build dependency.