Skip to content

fix(get_repo): verify git tag exists before fetching (issue #10) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbs44 merged 1 commit into from
Jun 10, 2026
Merged

fix(get_repo): verify git tag exists before fetching (issue #10) #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions get_repo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,24 @@ fi
echo "MS_TAG=\"${MS_TAG}\""
echo "MS_COMMIT=\"${MS_COMMIT}\""

# Verify the git tag is actually present in microsoft/vscode. The update API
# sometimes announces a new release before the git tag is pushed to GitHub,
# causing the fetch below to fail with the opaque "not our ref" error. If the
# tag is present but points at a different commit than what the API reported
# (e.g. after a force-push), adopt the git-authoritative hash since that is
# what GitHub can serve.
GIT_TAG_COMMIT=$( git ls-remote origin "refs/tags/${MS_TAG}" | awk '{print $1}' )
if [[ -z "${GIT_TAG_COMMIT}" ]]; then
echo "Error: Tag ${MS_TAG} is not yet present in microsoft/vscode (update API announced commit ${MS_COMMIT})."
echo "Microsoft typically pushes the git tag within a few hours of the binary release."
echo "The next scheduled cron run will retry automatically."
exit 1
fi
if [[ "${GIT_TAG_COMMIT}" != "${MS_COMMIT}" ]]; then
echo "Warning: git tag ${MS_TAG} points at ${GIT_TAG_COMMIT}, not update-API hash ${MS_COMMIT}; using git-authoritative hash."
MS_COMMIT="${GIT_TAG_COMMIT}"
fi

git fetch --depth 1 origin "${MS_COMMIT}"
git checkout FETCH_HEAD

Expand Down
Loading