Added support to follow ScriptBatchTerminator option#29
Closed
grijal wants to merge 6 commits into
Closed
Conversation
…-scripting # Conflicts: # DbUp.Support.SqlServer.Scripting.Console/DbUp.Support.SqlServer.Scripting.Console.csproj
# Conflicts: # DbUp.Support.SqlServer.Scripting/DbObjectScripter.cs
bradymholt
requested changes
Jun 13, 2018
| @@ -1,3 +1,20 @@ | |||
| # Changes in this fork: | |||
Owner
There was a problem hiding this comment.
Can you remove these changes to the README?
| @@ -1,76 +1,77 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Owner
There was a problem hiding this comment.
What is this diff? Can you revert changes to the project file?
| ScriptingUpgrader upgradeScriptingEngine = new ScriptingUpgrader(connectionString, engine); | ||
| Options options = new Options() | ||
| { | ||
| ScriptingOptions = new ScriptingOptions() |
Owner
There was a problem hiding this comment.
Rather than this being the default, and unable to be changed, can you use the same pattern as scriptAllDefinitions where it can be passed in as a arg?
| } | ||
| }; | ||
|
|
||
| // args = new string[] { "--scriptAllDefinitions" }; |
Owner
|
Superceded by #30. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support to follow ScriptBatchTerminator option so that "Go" statements are added at the end of script batches