Skip to content

Adding a branch alias on dev-master#8

Open
moufmouf wants to merge 1 commit into
brain-diminished:masterfrom
moufmouf:branch-alias
Open

Adding a branch alias on dev-master#8
moufmouf wants to merge 1 commit into
brain-diminished:masterfrom
moufmouf:branch-alias

Conversation

@moufmouf

@moufmouf moufmouf commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

The development version is on the master branch.
But your repository has a "master" and a "1.x" branch.
As it turns out, the 1.x branch is "behind" the currently tagged branch that all come from "master".

I was currently trying to get the fixes from #7 in TDBM.

I updated my composer.json like this:

        "brain-diminished/schema-version-control": "^1.0.5",

Since there is no 1.0.5 version tagged yet, I thought it would fallback to dev-master, but it actually picked the 1.x branch (which is late).

This PR adds a "branch-alias" (https://getcomposer.org/doc/articles/aliases.md#branch-alias) to composer.json so that "master" branch becomes the dev branch of 1.0.x releases.
In parallel of merging this, I think you should completely delete the 1.X branch.

The development version is on the master branch.
But your repository has a "master" and a "1.x" branch.
As it turns out, the 1.x branch is "behind" the currently tagged branch that all come from "master".

I was currently trying to get the fixes from brain-diminished#7 in TDBM.

I updated my composer.json like this:

```
        "brain-diminished/schema-version-control": "^1.0.5",
```

Since there is no 1.0.5 version tagged yet, I thought it would fallback to dev-master, but it actually picked the 1.x branch (which is late).

This PR adds a "branch-alias" (https://getcomposer.org/doc/articles/aliases.md#branch-alias) to composer.json so that "master" branch becomes the dev branch of 1.0.x releases.
In parallel of merging this, I think you should completely delete the 1.X branch.
@brain-diminished

Copy link
Copy Markdown
Owner

Sorry for the delay, I just returned from holidays!
I deleted the 1.x branch, it had no use indeed, and I added 1.0.5 so that latest stable version includes your last fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants