Add span origin provenance - #197
Open
Stephen Belanger (Qard) wants to merge 8 commits into
Open
Conversation
Andrew Kent (realark)
approved these changes
Jul 17, 2026
David Elner (delner)
requested changes
Jul 21, 2026
David Elner (delner)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for putting this together!
My major questions around this revolve around:
- Wrapper design / method missing. I'd consider this a blocker.
- Environment reading. I think we could better consolidate/organize this.
- Public API
from_envchange. Might be acceptable, just want to clarify on the story of how this overlaps with our state management story.
These things are manageable, but may require some significant refactoring.
Stephen Belanger (Qard)
force-pushed
the
agent/span-origin-provenance
branch
from
July 21, 2026 15:31
69ddfc5 to
56ff070
Compare
Stephen Belanger (Qard)
requested review from
David Elner (delner) and
Andrew Kent (realark)
July 21, 2026 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
mise exec ruby@3.2 -- bundle exec ruby -Ilib:test test/braintrust/config_test.rb test/braintrust/trace/span_filter_test.rb test/braintrust/trace/span_processor_test.rbmise exec ruby@3.2 -- bundle exec standardrb lib/braintrust/config.rb lib/braintrust/trace/span_filter.rb lib/braintrust/trace/span_processor.rb test/braintrust/config_test.rb