add bazel to lingua#369
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 430a891872
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| "scripts": { | ||
| "preinstall": "node -e \"const userAgent = process.env.npm_config_user_agent || ''; if (process.env.INIT_CWD === process.cwd() && !userAgent.includes('pnpm/')) { console.error('Use pnpm in this repo.'); process.exit(1); }\"", | ||
| "build": "pnpm run build:nodejs && pnpm run build:web && pnpm run prepare:pack", | ||
| "build": "if [ \"${BRAINTRUST_USE_BAZEL_WASM_PACK:-}\" = \"1\" ]; then bash ../../../tools/bazel/materialize_wasm_package.sh lingua; else pnpm run build:nodejs && pnpm run build:web; fi && pnpm run prepare:pack", |
There was a problem hiding this comment.
When BRAINTRUST_USE_BAZEL_WASM_PACK=1, pnpm run build now executes bash ../../../tools/bazel/materialize_wasm_package.sh lingua from bindings/lingua-wasm, which resolves outside this repository. I checked the repo for materialize_wasm_package.sh/tools/bazel and no such script is tracked, so any CI or publish path enabling this flag fails before producing the nodejs/web artifacts. Please add the script to the repo or point this branch at an existing checked-in path.
Useful? React with 👍 / 👎.
Alex Z (CLowbrow)
left a comment
Alex Z (CLowbrow)
left a comment
There was a problem hiding this comment.
I don't know what that comment from codex means so I'm going to approve.
2 participants
No description provided.