This repository was archived by the owner on Mar 4, 2026. It is now read-only.
BUGFIX: Don't compare node objects directly but rather compare their paths#24
Merged
breadlesscode merged 1 commit intobreadlesscode:masterfrom Jul 25, 2024
Conversation
Owner
|
Nice optimization. Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the mixin of your package on document nodes, that should actually be visible in the frontend. We just don't want their path segment in their childrens path.
However, if a path is generated to these pages, it would point to the parent page. The reason is, that you do compare if the starting node is the current node when checking if to consider the uri path segment or not. But you compare the objects instead of the path. One of the objects is put in a different context and thus, even though they are the same node, the equation returns false.
I changed it by checking if the paths are the same.