Skip to content

fix(pg-protocol): read ParameterDescription type OIDs as unsigned #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pratik-desgn wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

fix(pg-protocol): read ParameterDescription type OIDs as unsigned #3728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/pg-protocol/src/inbound-parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ const oneParameterDescBuf = buffers.parameterDescription([1111])

const twoParameterDescBuf = buffers.parameterDescription([2222, 3333])

const bigOidParameterDescBuf = buffers.parameterDescription([3000000003])

const expectedEmptyParameterDescriptionMessage = {
name: 'parameterDescription',
length: 6,
Expand All @@ -182,6 +184,13 @@ const expectedTwoParameterMessage = {
dataTypeIDs: [2222, 3333],
}

const expectedBigOidParameterMessage = {
name: 'parameterDescription',
length: 10,
parameterCount: 1,
dataTypeIDs: [3000000003],
}

const testForMessage = function (buffer: Buffer, expectedMessage: any) {
it('receives and parses ' + expectedMessage.name, async () => {
const messages = await parseBuffers([buffer])
Expand Down Expand Up @@ -288,6 +297,7 @@ describe('PgPacketStream', function () {
testForMessage(emptyParameterDescriptionBuffer, expectedEmptyParameterDescriptionMessage)
testForMessage(oneParameterDescBuf, expectedOneParameterMessage)
testForMessage(twoParameterDescBuf, expectedTwoParameterMessage)
testForMessage(bigOidParameterDescBuf, expectedBigOidParameterMessage)
})

describe('parsing rows', function () {
Expand Down
3 changes: 2 additions & 1 deletion packages/pg-protocol/src/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,8 @@ const parseParameterDescriptionMessage = (reader: BufferReader) => {
const parameterCount = reader.int16()
const message = new ParameterDescriptionMessage(LATEINIT_LENGTH, parameterCount)
for (let i = 0; i < parameterCount; i++) {
message.dataTypeIDs[i] = reader.int32()
// OIDs are unsigned, same as dataTypeID in parseField above
message.dataTypeIDs[i] = reader.uint32()
}
return message
}
Expand Down
Loading