Skip to content

Adding support for files to the content-plugin#3

Merged
dsimko merged 5 commits into
brix-cms:masterfrom
dsimko:feature_pictures
Feb 18, 2017
Merged

Adding support for files to the content-plugin#3
dsimko merged 5 commits into
brix-cms:masterfrom
dsimko:feature_pictures

Conversation

@dsimko

@dsimko dsimko commented Feb 11, 2017

Copy link
Copy Markdown
Member

It is possible to add images and attachments to a blog post.

Updated demo: http://46.183.65.66:8080/blog.html

@kbachl

kbachl commented Feb 12, 2017

Copy link
Copy Markdown
Member

I'm not sure you really want the URLs made by that...
e.g.: http://46.183.65.66:8080/content-plugin/bx_ZpWFOgGGBwmZbuHQxLkERLgc/5da7028e-19b5-4014-8bc0-fcf8484d4f0b
or http://46.183.65.66:8080/content-plugin/bx_ZpWFOgGGBwmZbuHQxLkERLgc/0193ac81-6efa-48d2-b995-a304fbbcefa1

is IMHO nightmare for any seo strategy... also from my wordpress experience one often reuses media files like images over more than 1 blog post...
beside, I'm not sure that exposing the workspace name/id is a good idea in terms of security (I know that security by obscurity is also a bad idea ;) )

maybe a distinct media workspaceor plugin would be better?
path then could be:

http://127.0.0.1/media-plugin/path/to/file/file.png

where "/media-plugin" could be configured on the plugin level in code...
or you use a reference to the site-workspace and allow to link images from there?

PS: I hope you dont see me as one who is only complaining - I really like you blog/content plugin

}

public void registerNodePlugin(NodeEditorPlugin plugin) {
if (plugin == null) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Args.notNull(plugin, "plugin") ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this will be nicer. I am going to change it. Thank you!

@dsimko

dsimko commented Feb 13, 2017

Copy link
Copy Markdown
Member Author

Thank you Korbinian, I've created #4 and I would like to discuss it later.

PS: I hope you dont see me as one who is only complaining - I really like you blog/content plugin

I really appreciate your feedback!

@dsimko dsimko merged commit 407cd9a into brix-cms:master Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants