Implement toWGPU() method for structs in adapter.zig device.zig - #28
Conversation
|
I can write some tests, in fact for those I can pretty much just copy/paste the current tests but pass in the optional data structures that were |
| } | ||
| }; | ||
|
|
||
| pub const WGPURequestAdapterOptions = extern struct { |
There was a problem hiding this comment.
Do we want to make all of these WGPU structs public? I've been changing them to private, but I suppose it wouldn't be a bad idea to expose them in some way, as long as it doesn't lead to confusion. I think in root.zig we should probably export them under their own namespace so we don't have people mistakenly mixing them with our wrapper code. There has been talk about Zig getting rid of usingnamespace so I need to do some work on root.zig soon anyway.
There was a problem hiding this comment.
That's up to you. I personally like to have things exposed so I can use them everywhere I'd need (especially types), but that's just me.
There was a problem hiding this comment.
Alright, I think let's make them public, but before we merge in the draft PR we put the WGPU structs into their own namespace.
2 participants
I am kind of unsure about some of these, so they may need some extra reviews... Or actual testing