Skip to content

Allow Chokidar options to be passed through#126

Closed
darend wants to merge 2 commits intobrowserify:masterfrom
sagansystems:chokidar
Closed

Allow Chokidar options to be passed through#126
darend wants to merge 2 commits intobrowserify:masterfrom
sagansystems:chokidar

Conversation

@darend
Copy link
Copy Markdown

@darend darend commented Jan 12, 2015

Issue: #120

@markwpearce
Copy link
Copy Markdown

+1
I like this!

@callerc1
Copy link
Copy Markdown

+1 please merge

@adrian-chang
Copy link
Copy Markdown

Can we merge this in! Super useful for those Docker Containers...

@nfvs
Copy link
Copy Markdown

nfvs commented Feb 26, 2015

+1

@brandonpapworth
Copy link
Copy Markdown

+1

1 similar comment
@jonbretman
Copy link
Copy Markdown

👍

@trungfinity
Copy link
Copy Markdown

Any update on this?

@tomi-roam
Copy link
Copy Markdown

+1

@jonbretman
Copy link
Copy Markdown

@substack - any thoughts on this?

@zertosh
Copy link
Copy Markdown
Member

zertosh commented Mar 23, 2015

@darend A couple of things: (1) What about command-line args? and docs? (2) You're mutating an opts object that doesn't belong to watchify - try something like:

var chokidarOpts = xtend({persistent: true}, opts.chokidar);

@zertosh
Copy link
Copy Markdown
Member

zertosh commented Mar 23, 2015

Sorry for the noise, turns out that this is a pretty common issue with a few nuances - closing and moving discussion to #162

@zertosh zertosh closed this Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.