Fix permissions error (EPERM) on Windows#159
Closed
ArtskydJ wants to merge 2 commits intobrowserify:masterfrom
ArtskydJ:fix-eperm2
Closed
Fix permissions error (EPERM) on Windows#159ArtskydJ wants to merge 2 commits intobrowserify:masterfrom ArtskydJ:fix-eperm2
ArtskydJ wants to merge 2 commits intobrowserify:masterfrom
ArtskydJ:fix-eperm2
Conversation
|
It would be good to know why this seems to fix the issue. Buffering up the contents sounds like it might be more related to a timing issue than the sequence of operations on disk.It looks like |
|
What happens in windows when: is changed to: with the |
Author
|
Writing straight to the outfile works great. PR here: #161 (The EPERM error was always thrown on the dotfile.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dotfile was getting permissions errors on windows.
This fixes the issue by buffering in memory rather than writing to a dotfile.
Memory usage was similar in my tests. (Write to dotfile: 42k, Buffer in memory: 42-44k.)
Fixes #83.
Related: #103, #104, #156.