Manage own ignoring instead of with chokidar#212
Closed
Conversation
Contributor
|
Just FYI you could simplify some of your logic here by using multimatch or micromatch with their built-in array handling instead of minimatch |
Member
Author
|
thanks @es128 - I'm trying to stick to the matching lib that browserify uses (minimatch via glob), but I liked what I saw in micromatch. |
Contributor
|
multimatch is a pretty thin wrapper around minimatch that will just handle the arrays for you. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid creating chokidar instances (#202 et al.)