Skip to content

update sanitizeSpecsPattern logic #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pranavj1001 merged 5 commits into from
Apr 24, 2024
Merged

update sanitizeSpecsPattern logic #788

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e1ffac
update sanitizeSpecsPattern logic
pranavj1001 Mar 5, 2024
c7082ee
Merge remote-tracking branch 'origin/master' into sanitize-glob-patte…
pranavj1001 Apr 10, 2024
812ad50
send correct config when enforce_settings is on
pranavj1001 Apr 14, 2024
9c3ec18
use new specPattern logic only when curly braces are passed
pranavj1001 Apr 18, 2024
deac31b
update specs
pranavj1001 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
update sanitizeSpecsPattern logic
  • Loading branch information
@pranavj1001
pranavj1001 committed Mar 5, 2024
commit 7e1ffac7b700ebfb645d92ddca12b2913370ccaa
2 changes: 1 addition & 1 deletion bin/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,7 @@ exports.getNumberOfSpecFiles = (bsConfig, args, cypressConfig, turboScaleSession
};

exports.sanitizeSpecsPattern = (pattern) => {
return pattern && pattern.split(",").length > 1 ? "{" + pattern + "}" : pattern;
return pattern && !(pattern.includes("{") && pattern.includes("}")) && pattern.split(",").length > 1 ? "{" + pattern + "}" : pattern;
}

exports.generateUniqueHash = () => {
Expand Down
4 changes: 4 additions & 0 deletions test/unit/bin/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2721,6 +2721,10 @@ describe('utils', () => {
expect(utils.sanitizeSpecsPattern('pattern3')).to.eq('pattern3');
});

it('should not wrap pattern around {} when input already has {}', () => {
expect(utils.sanitizeSpecsPattern('pattern/{folderA,folderB}/*.spec.ts')).to.eq('pattern/{folderA,folderB}/*.spec.ts');
});

it('should return undefined when --spec is undefined', () => {
expect(utils.sanitizeSpecsPattern(undefined)).to.eq(undefined);
});
Expand Down