Update logic for isCypressProjDirValid to handle windows path #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it('should return true when cypressProjDir and integrationFoldDir is same', () => { | ||
| expect(utils.isCypressProjDirValid('/absolute/path', '/absolute/path')).to.be.true; | ||
|
|
||
| // should be as below for windows but path.resolve thinks windows path as a filename when run on linux/mac |
Collaborator
There was a problem hiding this comment.
If that's the case , do we need to comment this and add one more expect ?
Collaborator
There was a problem hiding this comment.
This is for future use if we detect the platform is win32
karanshah-browserstack
approved these changes
Nov 5, 2020
| it('should return true when cypressProjDir and integrationFoldDir is same', () => { | ||
| expect(utils.isCypressProjDirValid('/absolute/path', '/absolute/path')).to.be.true; | ||
|
|
||
| // should be as below for windows but path.resolve thinks windows path as a filename when run on linux/mac |
Collaborator
There was a problem hiding this comment.
This is for future use if we detect the platform is win32
suryart
approved these changes
Nov 6, 2020
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrationFolderin cypress.json