Add quartiles, interquartiles and outliers functions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @vanakenm! I like the idea! Can you clean this up to not add all the semicolons in? It makes the diff a bit hard to read ;) I've been slowly adding |
Author
|
OK, I can understand that. I've been used prettier more & more, so I only
realized the diff afterward. I'll send a cleaned up version.
…On Sat, May 26, 2018 at 2:36 AM, Bryce Baril ***@***.***> wrote:
Hi @vanakenm <https://github.com/vanakenm>! I like the idea! Can you
clean this up to not add all the semicolons in? It makes the diff a bit
hard to read ;)
I've been slowly adding standard to my packages but I haven't gotten to
this one yet. Apologies for no linter here to provide guidance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAynbAywhYu8Qq6rTVUpKyI710NzKKBtks5t2KObgaJpZM4UGE5i>
.
--
*Martin Van Aken - **Freelance Enthusiast Developer*
Mobile : +32 486 899 652
Follow me on Twitter : @martinvanaken <http://twitter.com/martinvanaken>
Call me on Skype : vanakenm
Hang out with me : martin@joyouscoding.com
Contact me on LinkedIn : http://www.linkedin.com/in/martinvanaken
Company website : www.joyouscoding.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Found your lib which was exactly what I needed - a small stats package with histogram support. I needed some support to remove outliers, so here is the PR.
I found some mix of "standard" function and fat arrow ones, I used the latter when possible but did not touch the rest. In order to stay in the same convention I did not use let/const.
Just realized I had prettier "on save" - if this is a problem I can easily revert (I just added the methods mentioned, I did not touch anything else).