fix(extensions): preserve embedded permission policy#898
Merged
Conversation
| JarOutputStream jarOutput = new JarOutputStream(output, manifest)) { | ||
| if (entryName != null) { | ||
| jarOutput.putNextEntry(new JarEntry(entryName)); | ||
| jarOutput.write(contents.getBytes(StandardCharsets.ISO_8859_1)); |
ac732bd to
1f23534
Compare
698f2e6 to
5ab7614
Compare
176824e to
d73da4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BTrace-Extension-Permissionsis absent instead of silently granting an empty setFixes #877
Verification
:btrace-core:test -PtestJavaVersion=11suiteEmbeddedExtensionPermissionTest(embedded/filesystem parity, default denial, explicit allow)./gradlew spotlessCheck:btrace-gradle-plugin:compileGroovyBaseline limitations
The complete
:btrace-gradle-plugin:testrun reaches five unrelated failures already present ondevelop: two tests use the removed registry DSL, one expects the removedregistry(...)source, and two extension fixtures define a non-abstractShadowJarincompatible with Gradle 9.5. The current plugin build also pins JUnit 6.1.2 while targeting Java 11, so TestKit verification used a temporary local JUnit 5.14.4 pin and Java 17 test launcher; neither temporary change is included in this PR.This change is