fix(fat-agent): execute bundled probes end to end#899
Merged
Conversation
bb4f04c to
9ae0a20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
META-INF/btrace-probes/<binary-name>.classthe canonical standalone bundled-probe layoutprobes=and configurator-selected probes through that layoutFixes #878
Verification
:btrace-agent:testsuiteBUNDLED_PROBE_EXECUTED, application output,BUNDLED_PROBE_TORN_DOWN, and exit code 0./gradlew spotlessCheck:btrace-agent:compileJavaand:btrace-gradle-plugin:compileGroovyBaseline limitations
The complete
:btrace-gradle-plugin:testrun reaches five unrelated failures already present ondevelop: two tests use the removed registry DSL, one expects the removedregistry(...)source, and two extension fixtures define a non-abstractShadowJarincompatible with Gradle 9.5. The agent and plugin builds also pin JUnit 6.1.2 while compiling tests for Java 8/11, so verification used temporary local JUnit 5.14.4 pins and a Java 17 TestKit launcher; none of those temporary changes is included in this PR.This change is