colors mess up box formatting

[glennhartmann]

since the box formatting directly uses len(line), the extra ANSI escape codes contained in line cause the box code to believe a line will be longer than it actually gets displayed as

[xsteadfastx]

i have the same problem. trying to render a box with termenv formatted text in it.

[Vanclief]

Same problem, also happens with tables

[buger]

Can someone provide a test case?

Thanks!

[glennhartmann]

package main

import (
    "fmt"

    "github.com/buger/goterm"
)

func main() {
    const nums = "1234567890123456789012345678901234567890123456"

    b := goterm.NewBox(50, 10, 0)

    // no color - works fine
    fmt.Fprintln(b, nums)

    // color with short enough string - colors are ok, but border is in the wrong place
    fmt.Fprintln(b, goterm.Color(nums[:37], goterm.RED))

    // color with original string - border is in the wrong place, color doesn't get reset
    fmt.Fprintln(b, goterm.Color(nums, goterm.GREEN))

    // line length is fine, but demonstrates that color wasn't reset
    fmt.Fprintln(b, "string that's supposed to be default color")

    // reset the color manually - border is in wrong spot again
    fmt.Fprintln(b, goterm.RESET+"color is reset")

    // another normal line
    fmt.Fprintln(b, "hello, world")

    // for some reason at this specific string length, the borders just stop printing altogether
    fmt.Fprintln(b, goterm.Color(nums[:39], goterm.BLUE))

    goterm.Println(b.String())
    goterm.Flush()
}

[buger]

Fixed and published to a new release https://github.com/buger/goterm/releases/tag/v1.0.1

[Vanclief]

Thank you @buger