Skip to content

Fixed issue that "inappropriate ioctl for device"#10

Closed
Code-Hex wants to merge 1 commit intobuger:masterfrom
Code-Hex:master
Closed

Fixed issue that "inappropriate ioctl for device"#10
Code-Hex wants to merge 1 commit intobuger:masterfrom
Code-Hex:master

Conversation

@Code-Hex
Copy link

No description provided.

@buger
Copy link
Owner

buger commented Nov 15, 2016

Thank you for the PR!

There is few things I would like to point. First of all, GetSize function from crypto/ssh/terminal are really small https://github.com/golang/crypto/blob/master/ssh/terminal/util.go#L80, and we can just copy paste code from there. I do not think this package dependency is necessary.

Also I'm not sure that removing terminal_nosysioctl.go will work, crypto/ssh/terminal does not handle systems which do not support ioctl calls. Make sense to leave it as it is.

Thank you!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants