Fix "get Winsize redeclared in this block" due to platform build directives#34
Merged
buger merged 1 commit intobuger:masterfrom Apr 2, 2021
Merged
Conversation
…Winsize redeclared in this block" Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
ndeloof
reviewed
Apr 1, 2021
| @@ -1,4 +1,4 @@ | |||
| // +build !windows plan9 solaris | |||
Owner
|
Thank you! |
Owner
|
I also finally have created v1.0.0 release (and there is go modules support too), so you do not have to depend on master anymore :) |
Contributor
|
🍾 |
Owner
|
Btw, is there any requests on how to extend this library, is there anything basic missing? |
Contributor
|
nothing obvious doing a quick comparison with https://github.com/moby/term |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using last master version, ran into this on linux.
(Due to the added terminal_windows.go file)
tested the forked version of this PR on windows & linux, fixed, cf used lib here
Signed-off-by: Guillaume Tardif guillaume.tardif@gmail.com