fix: change Height() to return math.MaxInt if we could not retrieve t…#38
Merged
buger merged 1 commit intobuger:masterfrom Aug 26, 2021
Merged
Conversation
…he height of console window, otherwise nothing will be printed. Like in VSCode debugging console
Author
|
@buger hello buger, would you check this out? |
buger
approved these changes
Aug 26, 2021
Owner
|
Looks good, thank you! |
Owner
|
Releases as 1.0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change
func Height() intto return math.MaxInt when we could not retrieve the height of console window, otherwise nothing will be printed in that kind of environment.Like in VSCode debugging console.