Merged
Conversation
I was trying to use vctl which uses this library on a 32 bit machine
(Linux 3.14.0 armv7l) and failed to build.
../../buger/goterm/terminal.go:81: constant 2147483648 overflows int
../../buger/goterm/terminal.go:85: constant 2147483648 overflows int
This will cut the constant in half on 32 bit systems. I don't know if
this is right but it seemed to work. Happy to fix up the patch further,
I just don't understand what PCT is for.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to use vctl which uses this library on a 32 bit machine
(Linux 3.14.0 armv7l) and failed to build.
This will cut the constant in half on 32 bit systems. I don't know if
this is right but it seemed to work. Happy to fix up the patch further,
I just don't understand what PCT is for.