nogo: enable strings modern analyzers (#11558)

This PR enable a few "strings*" analyzers in the new modern package of
x/tools
to help us migrate our code to newer+better Go syntax.

It will also prevent future style violations by enforcing through
rules_go's nogo

The PR is split into 3 commits:
- Enable the analyzers (rules/go/analyzer/def.bzl)
- Apply all the style fixes
- Manual fixes

Author: sluongng

cli/arg/arg.go

@@ -59,8 +59,8 @@ func Find(args []string, desiredArg string) (value string, index int, length int
 			return args[i+1], i, 2
 		}
 		// Handle "--name=value" form
-		if strings.HasPrefix(arg, prefix) {
-			return strings.TrimPrefix(arg, prefix), i, 1
+		if after, ok := strings.CutPrefix(arg, prefix); ok {
+			return after, i, 1
 		}
 	}
 	return "", -1, 0

cli/cmd/sidecar/sidecar.go

@@ -116,8 +116,8 @@ func initializeEnv() *real_environment.RealEnv {
 func initializeGRPCServer(env *real_environment.RealEnv) (*grpc.Server, net.Listener) {
 	var lis net.Listener
 	var err error
-	if strings.HasPrefix(*listenAddr, "unix://") {
-		sockPath := strings.TrimPrefix(*listenAddr, "unix://")
+	if after, ok := strings.CutPrefix(*listenAddr, "unix://"); ok {
+		sockPath := after
 		lis, err = net.Listen("unix", sockPath)
 	} else {
 		lis, err = net.Listen("tcp", *listenAddr)
@@ -142,7 +142,7 @@ func initializeGRPCServer(env *real_environment.RealEnv) (*grpc.Server, net.List
 func registerBESProxy(env *real_environment.RealEnv, grpcServer *grpc.Server) {
 	buildEventProxyClients := make([]pepb.PublishBuildEventClient, 0)
 	targets := make([]string, 0)
-	for _, besBE := range strings.Split(*besBackend, ",") {
+	for besBE := range strings.SplitSeq(*besBackend, ",") {
 		besTarget := normalizeGrpcTarget(besBE)
 		targets = append(targets, besTarget)
 		buildEventProxyClients = append(buildEventProxyClients, build_event_proxy.NewBuildEventProxyClient(env, besTarget, *besSynchronous))

cli/config/config.go

@@ -142,8 +142,8 @@ func ParseDiskCapacityBytes(size any, directory string) (int64, error) {
 	case int64:
 		return v, nil
 	case string:
-		if strings.HasSuffix(v, "%") {
-			percentage, err := strconv.Atoi(strings.TrimSuffix(v, "%"))
+		if before, ok := strings.CutSuffix(v, "%"); ok {
+			percentage, err := strconv.Atoi(before)
 			if err != nil {
 				return 0, fmt.Errorf("parse percentage as int: %w", err)
 			}

cli/explain/compactgraph/compactgraph.go

@@ -301,7 +301,7 @@ func Diff(old, new *CompactGraph) (*spawn_diff.DiffResult, error) {
 					invalidatedByPrimaryOutput[s.PrimaryOutputPath()] = struct{}{}
 				}
 			}
-			for invalidatedBy, _ := range invalidatedByPrimaryOutput {
+			for invalidatedBy := range invalidatedByPrimaryOutput {
 				if invalidatingResultEntry, ok := diffResults.Load(invalidatedBy); ok {
 					invalidatingResult := invalidatingResultEntry.(*diffResult)
 					foundTransitiveCause = true
@@ -773,12 +773,12 @@ func diffRunfilesTrees(old, new *Spawn, oldResolveSymlinks, newResolveSymlinks f
 	newMapping := newTree.ComputeMapping(workspaceRunfilesDirectory, hashFunction)
 
 	var oldOnly, newOnly []string
-	for p, _ := range oldMapping {
+	for p := range oldMapping {
 		if _, ok := newMapping[p]; !ok {
 			oldOnly = append(oldOnly, p)
 		}
 	}
-	for p, _ := range newMapping {
+	for p := range newMapping {
 		if _, ok := oldMapping[p]; !ok {
 			newOnly = append(newOnly, p)
 		}

cli/fix/golang/golang.go

@@ -72,11 +72,12 @@ func (g *Golang) ConsolidateDepFiles(deps map[string][]string) map[string][]stri
 		return deps
 	}
 	if foundGoModFiles && len(goModFiles) > 1 {
-		goWorkContents := "go " + defaultGoVersion + "\n"
+		var goWorkContents strings.Builder
+		goWorkContents.WriteString("go " + defaultGoVersion + "\n")
 		for _, m := range goModFiles {
-			goWorkContents += "use ./" + path.Dir(m) + "\n"
+			goWorkContents.WriteString("use ./" + path.Dir(m) + "\n")
 		}
-		os.WriteFile(goWorkFileName, []byte(goWorkContents), 0777)
+		os.WriteFile(goWorkFileName, []byte(goWorkContents.String()), 0777)
 		delete(deps, goModFileName)
 	}
 	if foundGoWorkFiles && len(goWorkFiles) > 1 {

cli/help/help.go

@@ -94,8 +94,8 @@ func HandleHelp(args parsed.Args) (exitCode int, err error) {
 	// Match example "bazel help ..." commands in "Getting more help" section
 	moreHelpPattern := regexp.MustCompile(`^(\s*)bazel( help\s+.*)$`)
 	// Get help output lines with trailing newlines removed
-	lines := strings.Split(strings.TrimRight(buf.String(), "\n"), "\n")
-	for _, line := range lines {
+	lines := strings.SplitSeq(strings.TrimRight(buf.String(), "\n"), "\n")
+	for line := range lines {
 		line = strings.TrimRight(line, "\r")
 
 		if line == "Available commands:" {

cli/plugin/plugin.go

@@ -145,8 +145,8 @@ func HandleInstall(args []string) (exitCode int, err error) {
 
 func parsePluginSpec(spec, pathArg string) (*config.PluginConfig, error) {
 	var repoSpec, versionSpec, pathSpec string
-	if strings.HasPrefix(spec, ":") {
-		pathSpec = strings.TrimPrefix(spec, ":")
+	if after, ok := strings.CutPrefix(spec, ":"); ok {
+		pathSpec = after
 	} else {
 		m := repoPattern.FindStringSubmatch(spec)
 		if len(m) == 0 {

cli/record/record.go

@@ -92,7 +92,7 @@ func record(cmdArgs []string) (int, error) {
 	log.Debugf("Starting recording session with invocation ID: %s", iid)
 
 	invocationURL := fmt.Sprintf("%s/invocation/%s", *resultsURL, iid)
-	streamingLog := fmt.Sprintf(terminal.Esc(32) + "INFO:" + terminal.Esc() + fmt.Sprintf(" Streaming results to: %s", terminal.Esc(4, 34)+invocationURL+terminal.Esc()))
+	streamingLog := terminal.Esc(32) + "INFO:" + terminal.Esc() + fmt.Sprintf(" Streaming results to: %s", terminal.Esc(4, 34)+invocationURL+terminal.Esc())
 
 	fmt.Fprintln(os.Stderr, streamingLog)
 

cli/remotebazel/remotebazel.go

@@ -168,7 +168,7 @@ func determineRemote() (*gitRemote, error) {
 	}
 
 	remotes := make([]*gitRemote, 0)
-	for _, s := range strings.Split(remotesStr, "\n") {
+	for s := range strings.SplitSeq(remotesStr, "\n") {
 		s = strings.TrimSpace(s)
 		if s == "" {
 			continue
@@ -547,7 +547,7 @@ func generatePatches(baseCommit string) ([][]byte, error) {
 	binaryFilesToExclude := make([]string, 0)
 	binaryFiles := make([]string, 0)
 	if modifiedFiles != "" {
-		for _, mf := range strings.Split(modifiedFiles, "\n") {
+		for mf := range strings.SplitSeq(modifiedFiles, "\n") {
 			isBinary, err := isBinaryFile(mf)
 			if err != nil {
 				return nil, status.WrapError(err, "check binary file")
@@ -591,7 +591,7 @@ func generatePatches(baseCommit string) ([][]byte, error) {
 	}
 	untrackedFiles = strings.Trim(untrackedFiles, "\n")
 	if untrackedFiles != "" {
-		for _, uf := range strings.Split(untrackedFiles, "\n") {
+		for uf := range strings.SplitSeq(untrackedFiles, "\n") {
 			if strings.HasPrefix(uf, BuildBuddyArtifactDir+"/") {
 				continue
 			}
@@ -618,7 +618,7 @@ func splitLogBuffer(buf []byte) []string {
 	var lines []string
 
 	termWidth := getTermWidth()
-	for _, line := range strings.Split(string(buf), "\n") {
+	for line := range strings.SplitSeq(string(buf), "\n") {
 		for len(line) > termWidth {
 			lines = append(lines, line[0:termWidth])
 			line = line[termWidth:]

cli/sidecar/sidecar.go

@@ -357,8 +357,8 @@ func bytestreamURIPrefix(cacheTarget, instanceName string) string {
 
 func stripProtocol(target string) string {
 	for _, protocol := range []string{"grpc://", "grpcs://", "http://", "https://"} {
-		if strings.HasPrefix(target, protocol) {
-			return strings.TrimPrefix(target, protocol)
+		if after, ok := strings.CutPrefix(target, protocol); ok {
+			return after
 		}
 	}
 	return target