nogo: enable strings modern analyzers#11558
Merged
Conversation
sluongng
commented
Mar 12, 2026
sluongng
commented
Mar 12, 2026
sluongng
force-pushed
the
sluongng/modern-analyzer-strings
branch
from
8d03e7d to
d2b326b
Compare
sluongng
changed the title
vadimberezniker
approved these changes
Mar 13, 2026
sluongng
force-pushed
the
sluongng/modern-analyzer-strings
branch
from
0379837 to
b5ce5a2
Compare
Contributor
Author
|
Rebased to make sure everything passed before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enable a few "strings*" analyzers in the new modern package of x/tools
to help us migrate our code to newer+better Go syntax.
It will also prevent future style violations by enforcing through rules_go's nogo
The PR is split into 3 commits: