Skip to content

move the metrics for lease acquiring before sendRangeEvent #11289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luluz66 merged 1 commit into from
Feb 10, 2026
Merged

move the metrics for lease acquiring before sendRangeEvent #11289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions enterprise/server/raft/leasekeeper/leasekeeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,13 +191,13 @@ func (la *leaseAgent) doSingleInstruction(ctx context.Context, instruction *leas
return
}
la.log.Debugf("Acquired lease [%s] %s after callback (%s)", la.l.Desc(ctx), dur, instruction)
la.sendRangeEvent(events.EventRangeLeaseAcquired)
metrics.RaftLeases.With(prometheus.Labels{
metrics.RaftRangeIDLabel: strconv.Itoa(int(la.l.GetRangeID())),
}).Inc()
metrics.RaftLeaseActionDurationMsec.With(prometheus.Labels{
metrics.RaftLeaseActionLabel: leaseAction,
}).Observe(float64(dur.Milliseconds()))
la.sendRangeEvent(events.EventRangeLeaseAcquired)
case Drop:
// If the lease is already invalid, early-return here.
if !valid {
Expand All @@ -217,13 +217,13 @@ func (la *leaseAgent) doSingleInstruction(ctx context.Context, instruction *leas
return
}
la.log.Debugf("Dropped lease [%s] %s after callback (%s)", la.l.Desc(ctx), dur, instruction)
la.sendRangeEvent(events.EventRangeLeaseDropped)
metrics.RaftLeases.With(prometheus.Labels{
metrics.RaftRangeIDLabel: strconv.Itoa(int(rangeID)),
}).Dec()
metrics.RaftLeaseActionDurationMsec.With(prometheus.Labels{
metrics.RaftLeaseActionLabel: leaseAction,
}).Observe(float64(dur.Milliseconds()))
la.sendRangeEvent(events.EventRangeLeaseDropped)
}
}

Expand Down
Loading